Qualify the container image names to localhost #17645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen some occasional issues where containers are exiting prematurely. This may be to our config not qualifying the image name as the one located on localhost. With this change, we're being more explicit with that qualification. I've also updated some of the changes in the config where our CI is ahead.
JacobCallahan
added
TestFailure
damoore044
approved these changes
Feb 20, 2025
Gauravtalreja1
approved these changes
Feb 20, 2025
Gauravtalreja1
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
ACK, @JacobCallahan before merging, just wanted to confirm if this change needs to be cherrypicked to other branches ?
|
@Gauravtalreja1 i don't think so, since it's just the template. but if you disagree, feel free to tag the other branches |
damoore044
pushed a commit
to damoore044/robottelo
that referenced
this pull request
Feb 25, 2025
We've seen some occasional issues where containers are exiting prematurely. This may be to our config not qualifying the image name as the one located on localhost. With this change, we're being more explicit with that qualification. I've also updated some of the changes in the config where our CI is ahead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen some occasional issues where containers are exiting prematurely. This may be to our config not qualifying the image name as the one located on localhost.
With this change, we're being more explicit with that qualification. I've also updated some of the changes in the config where our CI is ahead.